From 89268a6d17fc87003b209a1422c17ab288be99a0 Mon Sep 17 00:00:00 2001 From: Jon Leech Date: Fri, 18 Jul 2025 12:20:26 +0100 Subject: [PATCH] Reorganization Makefile.release comments --- Makefile.release | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/Makefile.release b/Makefile.release index d7f6b7a..f438d07 100644 --- a/Makefile.release +++ b/Makefile.release @@ -106,6 +106,16 @@ update-scripts: # Once the branch is updated, push it to upstream and create an MR # This should be used cautiously after verifying the branch contents are # indeed correct and updates. +# +# Ideally we could automatically create the github PR. +# This will require additional software, see e.g. +# https://medium.com/@ravipatel.it/creating-a-git-pull-request-using-the-command-line-a-detailed-guide-4ef1ea017fe2 +# https://gist.github.com/devinschumacher/bc66c162d9c6c167952f1943d0e6419c +# Gitlab supports this via 'git push' options e.g. +# -o merge_request.create -o merge_request.target=main -o merge_request.remove_source_branch \ +# -o merge_request.title="Update for Vulkan-Docs 1.4.$(REVISION)" \ +# -o merge_request.assign=oddhack +# But for github we must manually create a PR after pushing push-branch: revision-check git switch $(BRANCH) git add -u @@ -113,15 +123,6 @@ push-branch: revision-check echo "Adding new files:" `git diff --name-only main` git add `git diff --name-only main` git commit -m "Update for Vulkan-Docs 1.4.$(REVISION)" - # Ideally we could automatically create the github PR. - # This will require additional software, see e.g. - # https://medium.com/@ravipatel.it/creating-a-git-pull-request-using-the-command-line-a-detailed-guide-4ef1ea017fe2 - # https://gist.github.com/devinschumacher/bc66c162d9c6c167952f1943d0e6419c - # Gitlab supports this via 'git push' options e.g. - # -o merge_request.create -o merge_request.target=main -o merge_request.remove_source_branch \ - # -o merge_request.title="Update for Vulkan-Docs 1.4.$(REVISION)" \ - # -o merge_request.assign=oddhack - # But for github we must manually create a PR after pushing git push --set-upstream origin $(BRANCH) git switch main git branch -d $(BRANCH)