Fix Windows GHA Tests

The Windows tests job in Github Actions was incorrectly reporting
'success' on failed runs. This change ensures a single command is run in
each test 'step' to help remove any guesswork w.r.t. the shell behavior
on each platform.

This change also takes the oppportunity to make the formatting more
consistent in continuous_integration.yml.
This commit is contained in:
Nathaniel Cesario 2023-10-24 13:58:41 -06:00 committed by ncesario-lunarg
parent e6fbb65699
commit ffac211098

View file

@ -59,10 +59,9 @@ jobs:
- name: Install - name: Install
run: cmake --install build --prefix build/install run: cmake --install build --prefix build/install
- name: Test - name: Test
run: | run: ctest --output-on-failure --test-dir build
cd build - name: Test (standalone)
ctest --output-on-failure && run: cd Test && ./runtests
cd ../Test && ./runtests
linux-asan: linux-asan:
runs-on: ubuntu-22.04 runs-on: ubuntu-22.04
@ -112,10 +111,9 @@ jobs:
- name: Install - name: Install
run: cmake --install build --prefix build/install run: cmake --install build --prefix build/install
- name: Test - name: Test
run: | run: ctest --output-on-failure --test-dir build
cd build - name: Test (standalone)
ctest --output-on-failure && run: cd Test && ./runtests
cd ../Test && ./runtests
# Ensure we can compile/run on an older distro # Ensure we can compile/run on an older distro
linux_min: linux_min:
@ -157,10 +155,9 @@ jobs:
- name: Install - name: Install
run: cmake --install build --prefix build/install run: cmake --install build --prefix build/install
- name: Test - name: Test
run: | run: ctest --output-on-failure --test-dir build
cd build - name: Test (standalone)
ctest --output-on-failure && run: cd Test && ./runtests
cd ../Test && ./runtests
macos: macos:
runs-on: ${{matrix.os}} runs-on: ${{matrix.os}}
@ -200,10 +197,9 @@ jobs:
- name: Install - name: Install
run: cmake --install build --prefix build/install run: cmake --install build --prefix build/install
- name: Test - name: Test
run: | run: ctest --output-on-failure --test-dir build
cd build - name: Test (standalone)
ctest --output-on-failure && run: cd Test && ./runtests
cd ../Test && ./runtests
windows: windows:
runs-on: ${{matrix.os.genus}} runs-on: ${{matrix.os.genus}}
@ -240,10 +236,9 @@ jobs:
cmake -S. -Bbuild -G "Visual Studio 16 2019" -A x64 -DCMAKE_INSTALL_PREFIX="$PWD/build/install" cmake -S. -Bbuild -G "Visual Studio 16 2019" -A x64 -DCMAKE_INSTALL_PREFIX="$PWD/build/install"
cmake --build build --config ${{matrix.cmake_build_type}} --target install cmake --build build --config ${{matrix.cmake_build_type}} --target install
- name: Test - name: Test
run: | run: ctest -C ${{matrix.cmake_build_type}} --output-on-failure --test-dir build
cd build - name: Test (standalone)
ctest -C ${{matrix.cmake_build_type}} --output-on-failure run: bash -c 'cd ./Test && ./runtests'
cd ../Test && bash runtests
android: android:
runs-on: ubuntu-22.04 runs-on: ubuntu-22.04