Fix OpImageRead result type when compiling HLSL (#2706)

Browse source

Fix OpImageRead result type when compiling HLSL

- Per the Vulkan spec, OpImageRead must return a 4-component vector always. When compiling HLSL, loads from a RWTexture of a template type with < 4 components would incorrectly generate an OpImageRead with a < 4 component result, resulting in validation errors.
- This was previously fixed for OpImageFetch in commit 4425f24; this commit does the same thing for OpImageRead.
- Added associated tests and expanded existing image fetch tests to check all the different types of textures, in both float and int incarnations, for completeness.
- Update other HLSL tests involving OpImageRead

...

This commit is contained in:

Nathan Reed 2021-07-28 08:29:17 -07:00 • committed by GitHub

parent 4a12ee1ae3

commit fc9897d1ba

No known key found for this signature in database

GPG key ID: 4AEE18F83AFDEB23

10 changed files with 2907 additions and 1673 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1657

Test/baseResults/hlsl.rw.vec2.bracket.frag.out

View file

File diff suppressed because it is too large Load diff