Implement implicit conversions of function-call arguments (both in and out) as explicit conversions in the AST, through handleArgumentConversions().

Also
 - uniformly handle EvqConstReadOnly as an input argument in a function, with 
   isParamInput() and isParamOutput() queries in TQualifier.
 - provide a makeTemporary() in TQualifier, for erasing original qualification when making a temp
 - provide a makeInternalVariable() call to make a shader variable not seen in the shader source


git-svn-id: https://cvs.khronos.org/svn/repos/ogl/trunk/ecosystem/public/sdk/tools/glslang@25912 e7fa87d3-cd2b-0410-9028-fcbf551c1848

glslang/Include/BaseTypes.h

@@ -74,8 +74,7 @@ enum TStorageQualifier {
     EvqIn,            // also, for 'in' in the grammar before we know if it's a pipeline input or an 'in' parameter
     EvqOut,           // also, for 'out' in the grammar before we know if it's a pipeline output or an 'out' parameter
     EvqInOut,
-
-    EvqConstReadOnly, // read-only types, not having a constant value or constant-value semantics
+    EvqConstReadOnly, // input; also other read-only types having neither a constant value nor constant-value semantics
 
     // built-ins read by vertex shader
     EvqVertexId,

glslang/Include/Types.h

@@ -238,9 +238,15 @@ class TQualifier {
 public:
     void clear()
     {
-        storage   = EvqTemporary;
         precision = EpqNone;
         invariant = false;
+        makeTemporary();
+    }
+
+    // drop qualifiers that don't belong in a temporary variable
+    void makeTemporary()
+    {
+        storage   = EvqTemporary;
         centroid  = false;
         smooth    = false;
         flat      = false;
@@ -255,6 +261,7 @@ public:
         writeonly = false;
         clearLayout();
     }
+
     TStorageQualifier   storage   : 6;
     TPrecisionQualifier precision : 3;
     bool invariant : 1;
@@ -314,6 +321,29 @@ public:
         }
     }
 
+    bool isParamInput() const
+    {
+        switch (storage) {
+        case EvqIn:
+        case EvqInOut:
+        case EvqConstReadOnly:
+            return true;
+        default:
+            return false;
+        }
+    }
+
+    bool isParamOutput() const
+    {
+        switch (storage) {
+        case EvqOut:
+        case EvqInOut:
+            return true;
+        default:
+            return false;
+        }
+    }
+
     bool isUniform() const
     {
         switch (storage) {

glslang/Include/intermediate.h

@@ -247,7 +247,7 @@ enum TOperator {
     //
 
     EOpConstructGuardStart,
-    EOpConstructInt,
+    EOpConstructInt,          // these first scalar forms also identify what implicit conversion is needed
     EOpConstructUint,
     EOpConstructBool,
     EOpConstructFloat,