BeeEngine/glslang-zig
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add some comments and rename a helper function

Browse source 
This adds some documentation of the checkTypes() function to make
clearer what exactly it is checking.
This commit is contained in:
Arcady Goldmints-Orlov 2024-07-18 18:16:20 -04:00 • committed by arcady-lunarg
parent dc9f6f61ad
commit 74d448cc15
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
glslang/MachineIndependent/linkValidate.cpp
View file

@ -1736,7 +1736,10 @@ int TIntermediate::addUsedLocation(const TQualifier& qualifier, const TType& typ
return collision;
}
static bool checkType(TBasicType t1, TBasicType t2) {
// Check that two types can be stored in different components in the same location.
// They must be the same type, except signed/unsigned integers are considered compatible.
static bool checkCompatibleTypes(TBasicType t1, TBasicType t2) {
if (t1 != t2) {
if ((t1 == EbtInt8 && t2 == EbtUint8) ||
(t2 == EbtInt8 && t1 == EbtUint8) ||
@ -1751,6 +1754,7 @@ static bool checkType(TBasicType t1, TBasicType t2) {
}
return t1 == t2;
}
// Compare a new (the passed in) 'range' against the existing set, and see
// if there are any collisions.
//
@ -1763,7 +1767,7 @@ int TIntermediate::checkLocationRange(int set, const TIoRange& range, const TTyp
// there is a collision; pick one
return std::max(range.location.start, usedIo[set][r].location.start);
} else if (range.location.overlap(usedIo[set][r].location) &&
(!checkType(type.getBasicType(), usedIo[set][r].basicType) ||
(!checkCompatibleTypes(type.getBasicType(), usedIo[set][r].basicType) ||
type.getQualifier().centroid != usedIo[set][r].centroid ||
type.getQualifier().smooth != usedIo[set][r].smooth ||
type.getQualifier().flat != usedIo[set][r].flat ||