BeeEngine/glslang-zig
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove redundant calls to spv::Parameterize() from tests

Browse source 
This means the tests won't need to have this entrypoint exposed when
building as a shared library with hidden symbols.
This commit is contained in:
Arcady Goldmints-Orlov 2024-09-11 09:46:38 -07:00 • committed by arcady-lunarg
parent 12a17b7ce4
commit 6495f77b04
4 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
gtests/GlslMapIO.FromFile.cpp
View file

@ -312,7 +312,6 @@ TEST_P(GlslMapIOTest, FromFile)
spirv_binary, &logger, &options()); spirv_binary, &logger, &options());
std::ostringstream disassembly_stream; std::ostringstream disassembly_stream;
spv::Parameterize();
spv::Disassemble(disassembly_stream, spirv_binary); spv::Disassemble(disassembly_stream, spirv_binary);
result.spirvWarningsErrors += logger.getAllMessages(); result.spirvWarningsErrors += logger.getAllMessages();
result.spirv += disassembly_stream.str(); result.spirv += disassembly_stream.str();

1
gtests/Link.FromFile.Vk.cpp
View file

@ -86,7 +86,6 @@ TEST_P(LinkTestVulkan, FromFile)
spirv_binary, &logger, &options()); spirv_binary, &logger, &options());
std::ostringstream disassembly_stream; std::ostringstream disassembly_stream;
spv::Parameterize();
spv::Disassemble(disassembly_stream, spirv_binary); spv::Disassemble(disassembly_stream, spirv_binary);
result.spirvWarningsErrors = logger.getAllMessages(); result.spirvWarningsErrors = logger.getAllMessages();
result.spirv = disassembly_stream.str(); result.spirv = disassembly_stream.str();

4
gtests/TestFixture.h
View file

@ -324,7 +324,6 @@ public:
} }
std::ostringstream disassembly_stream; std::ostringstream disassembly_stream;
spv::Parameterize();
spv::Disassemble(disassembly_stream, spirv_binary); spv::Disassemble(disassembly_stream, spirv_binary);
bool validation_result = !options().validate || logger.getAllMessages().empty(); bool validation_result = !options().validate || logger.getAllMessages().empty();
return {{ return {{
@ -384,7 +383,6 @@ public:
spirv_binary, &logger, &options()); spirv_binary, &logger, &options());
std::ostringstream disassembly_stream; std::ostringstream disassembly_stream;
spv::Parameterize();
spv::Disassemble(disassembly_stream, spirv_binary); spv::Disassemble(disassembly_stream, spirv_binary);
bool validation_result = !options().validate || logger.getAllMessages().empty(); bool validation_result = !options().validate || logger.getAllMessages().empty();
return {{{shaderName, shader.getInfoLog(), shader.getInfoDebugLog()},}, return {{{shaderName, shader.getInfoLog(), shader.getInfoDebugLog()},},
@ -429,7 +427,6 @@ public:
spv::spirvbin_t(0 /*verbosity*/).remap(spirv_binary, whiteListStrings, remapOptions); spv::spirvbin_t(0 /*verbosity*/).remap(spirv_binary, whiteListStrings, remapOptions);
std::ostringstream disassembly_stream; std::ostringstream disassembly_stream;
spv::Parameterize();
spv::Disassemble(disassembly_stream, spirv_binary); spv::Disassemble(disassembly_stream, spirv_binary);
bool validation_result = !options().validate || logger.getAllMessages().empty(); bool validation_result = !options().validate || logger.getAllMessages().empty();
return {{{shaderName, shader.getInfoLog(), shader.getInfoDebugLog()},}, return {{{shaderName, shader.getInfoLog(), shader.getInfoDebugLog()},},
@ -453,7 +450,6 @@ public:
spv::spirvbin_t(0 /*verbosity*/).remap(spirv_binary, whiteListStrings, remapOptions); spv::spirvbin_t(0 /*verbosity*/).remap(spirv_binary, whiteListStrings, remapOptions);
std::ostringstream disassembly_stream; std::ostringstream disassembly_stream;
spv::Parameterize();
spv::Disassemble(disassembly_stream, spirv_binary); spv::Disassemble(disassembly_stream, spirv_binary);
return {{{shaderName, "", ""},}, return {{{shaderName, "", ""},},

1
gtests/VkRelaxed.FromFile.cpp
View file

@ -264,7 +264,6 @@ TEST_P(VulkanRelaxedTest, FromFile)
spirv_binary, &logger, &options()); spirv_binary, &logger, &options());
std::ostringstream disassembly_stream; std::ostringstream disassembly_stream;
spv::Parameterize();
spv::Disassemble(disassembly_stream, spirv_binary); spv::Disassemble(disassembly_stream, spirv_binary);
result.spirvWarningsErrors += logger.getAllMessages(); result.spirvWarningsErrors += logger.getAllMessages();
result.spirv += disassembly_stream.str(); result.spirv += disassembly_stream.str();