BeeEngine/glslang-zig
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tweak error behavior for redeclared uniforms for vulkan-relaxed

Browse source 
avoids nullptr crash from reading memberType's name, and more user
friendly error message.
This commit is contained in:
Malcolm Bechard 2023-10-30 15:28:36 -04:00 • committed by arcady-lunarg
parent f8dd5adde4
commit 1dde7113bb
3 changed files with 59 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

6
glslang/MachineIndependent/ParseContextBase.cpp
View file

@ -626,10 +626,8 @@ void TParseContextBase::growGlobalUniformBlock(const TSourceLoc& loc, TType& mem
if (symbol) {
if (memberType != symbol->getType()) {
TString err;
err += "\"" + memberType.getCompleteString() + "\"";
err += " versus ";
err += "\"" + symbol->getType().getCompleteString() + "\"";
error(loc, "Types must match:", memberType.getFieldName().c_str(), err.c_str());
err += "Redeclaration: already declared as \"" + symbol->getType().getCompleteString() + "\"";
error(loc, "", memberName.c_str(), err.c_str());
}
return;
}