BeeEngine/glslang-zig
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix #2020: PR #1977 broke HLSL member consistency, this finishes it...

Browse source 
using an unitialized member.  This commit consistently does not use those
HLSL members unless ENABLE_HLSL is on.
This commit is contained in:
John Kessenich 2019-12-09 23:48:50 -07:00
parent 1afa2b8cc5
commit 1843c0c415
2 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
glslang/Include/Types.h
View file

@ -82,11 +82,6 @@ struct TSampler { // misnomer now; includes images, textures without sampler,
bool sampler : 1; // true means a pure sampler, other fields should be clear()
#ifdef GLSLANG_WEB
unsigned int getVectorSize() const { return 4; }
void clearReturnStruct() const { }
bool hasReturnStruct() const { return false; }
unsigned getStructReturnIndex() const { return 0; }
bool is1D() const { return false; }
bool isBuffer() const { return false; }
bool isRect() const { return false; }
@ -111,10 +106,12 @@ struct TSampler { // misnomer now; includes images, textures without sampler,
bool external : 1; // GL_OES_EGL_image_external
bool yuv : 1; // GL_EXT_YUV_target
#ifdef ENABLE_HLSL
unsigned int getVectorSize() const { return vectorSize; }
void clearReturnStruct() { structReturnIndex = noReturnStruct; }
bool hasReturnStruct() const { return structReturnIndex != noReturnStruct; }
unsigned getStructReturnIndex() const { return structReturnIndex; }
#endif
bool is1D() const { return dim == Esd1D; }
bool isBuffer() const { return dim == EsdBuffer; }
@ -225,9 +222,12 @@ struct TSampler { // misnomer now; includes images, textures without sampler,
isCombined() == right.isCombined() &&
isPureSampler() == right.isPureSampler() &&
isExternal() == right.isExternal() &&
isYuv() == right.isYuv() &&
getVectorSize() == right.getVectorSize() &&
getStructReturnIndex() == right.getStructReturnIndex();
isYuv() == right.isYuv()
#ifdef ENABLE_HLSL
&& getVectorSize() == right.getVectorSize() &&
getStructReturnIndex() == right.getStructReturnIndex()
#endif
;
}
bool operator!=(const TSampler& right) const

2
glslang/MachineIndependent/SymbolTable.cpp
View file

@ -114,6 +114,7 @@ void TType::buildMangledName(TString& mangledName) const
default: break; // some compilers want this
}
#ifdef ENABLE_HLSL
if (sampler.hasReturnStruct()) {
// Name mangle for sampler return struct uses struct table index.
mangledName += "-tx-struct";
@ -129,6 +130,7 @@ void TType::buildMangledName(TString& mangledName) const
case 4: break; // default to prior name mangle behavior
}
}
#endif
if (sampler.isMultiSample())
mangledName += "M";