BeeEngine/glslang-zig
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix off-by-1 bug in gl_MaxCombinedTextureImageUnits check

Browse source 
The problem was only with arrays of samplers.

Fixed #2552
This commit is contained in:
Greg Fischer 2021-02-26 16:59:51 -07:00
parent 3839066ee4
commit 051fbbb69c
3 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
glslang/MachineIndependent/ParseHelper.cpp
View file

@ -5913,16 +5913,12 @@ void TParseContext::layoutTypeCheck(const TSourceLoc& loc, const TType& type)
if (type.getBasicType() == EbtSampler) {
int lastBinding = qualifier.layoutBinding;
if (type.isArray()) {
if (spvVersion.vulkan > 0)
lastBinding += 1;
else {
if (spvVersion.vulkan == 0) {
if (type.isSizedArray())
lastBinding += type.getCumulativeArraySize();
lastBinding += (type.getCumulativeArraySize() - 1);
else {
lastBinding += 1;
#ifndef GLSLANG_WEB
if (spvVersion.vulkan == 0)
warn(loc, "assuming binding count of one for compile-time checking of binding numbers for unsized array", "[]", "");
warn(loc, "assuming binding count of one for compile-time checking of binding numbers for unsized array", "[]", "");
#endif
}
}